Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.00%. Comparing base (cab321d) to head (8e8fc2c).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main     #878   +/-   ##
=======================================
  Coverage   94.00%   94.00%           
=======================================
  Files          55       55           
  Lines        2720     2720           
  Branches      852      852           
=======================================
  Hits         2557     2557           
  Misses         87       87           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpadioleau

Following changes are needed?

1. Only expose is_<check>_v
2. Add docs to is_<check>_v
3. Use parentheses to &&?

template <class Builder, class Evaluator>
 struct is_spline_compatible<Builder, Evaluator,
        std::enable_if_t<is_spline_builder_v<Builder> && is_spline_evaluator_v<Evaluator>
                         || is_spline_builder_v<Evaluator> && is_spline_evaluator_v<Builder> >>

Should be

template <class Builder, class Evaluator>
 struct is_spline_compatible<Builder, Evaluator,
        std::enable_if_t<(is_spline_builder_v<Builder> && is_spline_evaluator_v<Evaluator>)
                         || (is_spline_builder_v<Evaluator> && is_spline_evaluator_v<Builder>) >>

@tpadioleau

Following changes are needed?

1. Only expose is_<check>_v

You can keep is_<check> in the current namespace as the other traits. We can put them in a detail namespace later.

2. Add docs to is_<check>_v

Yes please

3. Use parentheses to &&?

Yes I guess the point of the linter is to clarify the intent.

@tpadioleau
Following changes are needed?

1. Only expose is_<check>_v

You can keep is_<check> in the current namespace as the other traits. We can put them in a detail namespace later.

OK

2. Add docs to is_<check>_v

Yes please

What kind of docstrings do you prefer?
I could not see docs for these constants.
is_chunk_v

3. Use parentheses to &&?

Yes I guess the point of the linter is to clarify the intent.

OK

@tpadioleau Can you format this
clangformat 20 is unavailable on my env

@tpadioleau Can you format this clangformat 20 is unavailable on my env

Done